-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
std.os.uefi.protocol.File: fix some typed definitions #23443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusg
reviewed
Apr 2, 2025
linusg
approved these changes
Apr 2, 2025
|
Gonna wait a bit before merging so @truemedian can review this too. |
truemedian
reviewed
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me other than a few nitpicks that are unrelated to fixing the original issue.
linusg
reviewed
Apr 3, 2025
truemedian
approved these changes
Apr 4, 2025
|
Oops, I meant to do a squash merge - apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23214 has a few glitches, this is a PR fixing one of them :)
there were 3 issues with
Fileas pointed out by #23436:File.openin the spec, the
OpenModeargument can only beread,read|write, orread|write|execute. However, currently the interface only allowsread,write, andexecute. This PR addresses this problem:OpenMode.Bitswhich provides a bitfield representing those values from the specOpenMode's enum tags are renamed toread,read_write, andread_write_createfor better clarityOpenMode's enum values are implemented by bitcastingOpenMode.BitsvaluesFile.getInfoThe file info buffer should be larger than
@sizeOf(Info.*), becauseInfo.*types have an attached null-terminated string at the end.This method now requires the user to pass in a buffer which will contain the resulting info type.
To better align with the pattern being established in #23441, this function's return type is now
struct { usize, ?*Payload }.File.setInfoThe
lenaccounting as-is is wrong. It should account for the length of the attached null-terminated string.closes #23436